Skip to content

fix(@angular-devkit/build-angular): serve assets from the provided serve-path #26511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

alan-agius4
Copy link
Collaborator

When the serve-path option is used assets are now correctly servered from this location.

Closes #26509

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Nov 28, 2023
@alan-agius4 alan-agius4 force-pushed the assets-serve-path-vite branch from 45f7c1a to 0544d82 Compare November 28, 2023 08:44
@alan-agius4 alan-agius4 requested a review from clydin November 28, 2023 11:47
@alan-agius4 alan-agius4 force-pushed the assets-serve-path-vite branch from 0544d82 to ce57b7b Compare November 28, 2023 14:52
@alan-agius4 alan-agius4 force-pushed the assets-serve-path-vite branch 6 times, most recently from 65ee520 to 5805db1 Compare November 28, 2023 15:20
…erve-path`

When the `serve-path` option is used assets are now correctly servered from this location.

Closes angular#26509
@alan-agius4 alan-agius4 force-pushed the assets-serve-path-vite branch from c89bbaa to b7d526d Compare November 28, 2023 15:21
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 28, 2023
@alan-agius4 alan-agius4 merged commit 150a2e7 into angular:main Nov 28, 2023
@alan-agius4 alan-agius4 deleted the assets-serve-path-vite branch November 28, 2023 15:56
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assets folder not working when using ng serve with --serve-path
2 participants